Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic-contract-caller E2E test #2085

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Jan 30, 2024

Originally added as part of #2077, no longer required there but it is useful on its own nonetheless.

@ascjones ascjones enabled auto-merge (squash) January 31, 2024 12:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5674b4d) 53.69% compared to head (70fd6d2) 53.69%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2085   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files         223      223           
  Lines        7043     7043           
  Branches     3121     3121           
=======================================
  Hits         3782     3782           
  Misses       3261     3261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ascjones ascjones merged commit 7de0fd8 into master Jan 31, 2024
22 checks passed
@ascjones ascjones deleted the aj/basic-contract-caller-e2e-test branch January 31, 2024 12:42
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
basic-contract-caller 3.303 3.303 0 0
basic-contract-caller/other-contract 1.583 1.583 0 0
call-builder-return-value 9.169 9.169 0 0
call-runtime 2.061 2.061 0 0
combined-extension 2.137 2.12 -0.017 -0.795508 📉
conditional-compilation 1.49 1.49 0 0
contract-storage 7.568 7.568 0 0
contract-terminate 1.329 1.329 0 0
contract-transfer 1.689 1.689 0 0
custom-allocator 7.775 7.775 0 0
custom-environment 2.146 2.146 0 0
dns 7.318 7.318 0 0
e2e-call-runtime 1.296 1.296 0 0
e2e-runtime-only-backend 1.881 1.881 0 0
erc1155 14.237 14.237 0 0
erc20 6.918 6.918 0 0
erc721 9.873 9.873 0 0
events 5.258 5.258 0 0
flipper 1.639 1.639 0 0
incrementer 1.504 1.504 0 0
lang-err-integration-tests/call-builder-delegate 2.638 2.638 0 0
lang-err-integration-tests/call-builder 5.066 5.066 0 0
lang-err-integration-tests/constructors-return-value 1.985 1.985 0 0
lang-err-integration-tests/contract-ref 4.629 4.629 0 0
lang-err-integration-tests/integration-flipper 1.815 1.815 0 0
lazyvec-integration-test 4.616 4.616 0 0
mapping-integration-tests 7.999 7.999 0 0
mother 12.741 12.741 0 0
multi-contract-caller 6.106 6.106 0 0
multi-contract-caller/accumulator 1.378 1.378 0 0
multi-contract-caller/adder 1.968 1.968 0 0
multi-contract-caller/subber 1.988 1.988 0 0
multisig 21.688 21.688 0 0
payment-channel 5.659 5.659 0 0
psp22-extension 7.071 7.071 0 0
rand-extension 2.965 2.965 0 0
sr25519-verification 1.142 1.142 0 0
static-buffer 1.654 1.654 0 0
trait-dyn-cross-contract-calls 2.793 2.793 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.545 1.545 0 0
trait-erc20 7.294 7.294 0 0
trait-flipper 1.49 1.49 0 0
trait-incrementer 1.614 1.614 0 0
upgradeable-contracts/delegator 3.151 3.151 0 0
upgradeable-contracts/delegator/delegatee 1.609 1.609 0 0
upgradeable-contracts/set-code-hash 1.743 1.743 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.721 1.721 0 0
wildcard-selector 2.846 2.846 0 0

Link to the run | Last update: Wed Jan 31 14:01:07 CET 2024

ascjones added a commit that referenced this pull request Feb 1, 2024
* add e2e tests to basic-contract-caller example

* Fix basic-contract-caller e2e tests

* Remove `call_builder` change

* Remove `basic_contract_caller` integration test, moved to #1909

* Revert "Remove `basic_contract_caller` integration test, moved to #1909"

This reverts commit 8f3ab31.

* fmt
ascjones added a commit that referenced this pull request Feb 8, 2024
* init call_v2 methods and types

* add e2e tests to basic-contract-caller example

* Add storage_deposit

* Fix basic-contract-caller e2e tests

* Remove `basic_contract_caller` integration test, moved to #1909

* WIP adding cross_contract_calls test

* Add `integration-test` for possible migration pattern (#1909)

* WIP

* Update versions

* WIP

* WIP migration

* WIP

* Make test pass

* Move e2e tests mod to own file

* Update comment

* Update example for new e2e API

* Update integration-tests/upgradeable-contracts/set-code-hash-migration/lib.rs

Co-authored-by: Michael Müller <[email protected]>

* Top level gitignore

* Fix tests update comments

* Update upgradeable contracts README.md

* spelling

---------

Co-authored-by: Michael Müller <[email protected]>

* Add `basic-contract-caller` E2E test (#2085)

* add e2e tests to basic-contract-caller example

* Fix basic-contract-caller e2e tests

* Remove `call_builder` change

* Remove `basic_contract_caller` integration test, moved to #1909

* Revert "Remove `basic_contract_caller` integration test, moved to #1909"

This reverts commit 8f3ab31.

* fmt

* Only need one .gitignore

* WIP adding create v2 API

* Revert "WIP adding create v2 API"

This reverts commit bd83e18.

* WIP e2e tests

* Add CallV2 builder methods

* Pass weight limit as params

* Allow deprecated

* Add storage_deposit_limit

* Clippy

* Use struct update syntax

* Remove space

* CHANGELOG

* fmt

* Import OtherContract directly instead of reexporting

* Make other_contract pub

* Revert prev

* docs

* top level gitignore for integration-tests

* Remove unused setters

* Use ContractRef

* integration-test comments

* Rename to `call_v2`

* Comments and builder method

* SP

* comments

* fix doc test

---------

Co-authored-by: Michael Müller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants