Closed
Conversation
Artemka374
requested review from
HCastano,
SkymanOne,
ascjones and
cmichi
as code owners
ascjones
reviewed
May 22, 2023
deuszx
reviewed
Jun 15, 2023
deuszx
reviewed
Jun 15, 2023
| where | ||
| E: Environment, | ||
| { | ||
| unimplemented!("off-chain environment does not support `reentrance_count`") |
Contributor
Author
There was a problem hiding this comment.
I am not sure, that we should implement it in this PR, along with the fact, that we need to expand ExecContext in off-chain engine, so it looks for me as a point for another PR, maybe something like this: #1589
Collaborator
|
Merge |
|
What needs to be done here to get it merged? I can help with the coding work. |
SkymanOne
reviewed
Aug 18, 2023
Contributor
SkymanOne
left a comment
SkymanOne
left a comment
There was a problem hiding this comment.
Looks quite good for the first iteration. However, I am not fun of renaming set_allow_reentry()
Contributor
|
Hey @Artemka374 Any plans on picking this PR up again or should I close it? |
Contributor
|
Closing due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of work on #1507
which is a part of #1285