Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify fallible and non fallible instantiate methods #1591

Merged
merged 58 commits into from
Jan 24, 2023
Merged

Unify fallible and non fallible instantiate methods #1591

merged 58 commits into from
Jan 24, 2023

Commits on Jan 24, 2023

  1. Remove fallible create_builder.rs methods

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3758e09 View commit details
    Browse the repository at this point in the history

  2. WIP experiment

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    cdcc502 View commit details
    Browse the repository at this point in the history

  3. InstantiateResult blanket impl for T and Result

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6f59077 View commit details
    Browse the repository at this point in the history

  4. Introduce ContractRef type parameter

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    baecba9 View commit details
    Browse the repository at this point in the history

  5. Fix up env access

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    af69cd5 View commit details
    Browse the repository at this point in the history

  6. WIP...

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e134a8c View commit details
    Browse the repository at this point in the history

  7. Make it compile

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    115dd9f View commit details
    Browse the repository at this point in the history

  8. Add ContractStorage parameter

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    718d475 View commit details
    Browse the repository at this point in the history

  9. Remove commented out instantiate_fallible_contract

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bb5042e View commit details
    Browse the repository at this point in the history

  10. Convert to env Error in helper

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    528cfe0 View commit details
    Browse the repository at this point in the history

  11. Return Decode errors in case of invalid Result first byte

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    7b4c5e9 View commit details
    Browse the repository at this point in the history

  12. Fix impls::instantiate_contract

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4de38f5 View commit details
    Browse the repository at this point in the history

  13. Remove ContractStorage generic parameter

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    09545fe View commit details
    Browse the repository at this point in the history

  14. Fix env access

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    2ef624d View commit details
    Browse the repository at this point in the history

  15. Use generated constructor ref, introduces update_selector

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    02f97b1 View commit details
    Browse the repository at this point in the history

  16. Fix e2e

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    39b45b0 View commit details
    Browse the repository at this point in the history

  17. Remove commented out code

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    dc2f7bb View commit details
    Browse the repository at this point in the history

  18. Typos

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    39ab13f View commit details
    Browse the repository at this point in the history

  19. Clippy

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    60e7e90 View commit details
    Browse the repository at this point in the history

  20. Rename some instantiate_fallible

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    43c2fe0 View commit details
    Browse the repository at this point in the history

  21. Restore returns method

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bf3055c View commit details
    Browse the repository at this point in the history

  22. Remove ContractReference Result impl

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    322ab26 View commit details
    Browse the repository at this point in the history

  23. WIP implementing ConstructorReturnType

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e61a12b View commit details
    Browse the repository at this point in the history

  24. Reorder ContractRef parameter, move ContractRef and ContractEnv trait… 

    … to env crate
    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    62052a6 View commit details
    Browse the repository at this point in the history

  25. Fmt and fix

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    2ed5093 View commit details
    Browse the repository at this point in the history

  26. Remove E param from build_create

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    df4a067 View commit details
    Browse the repository at this point in the history

  27. Fix up build_create

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0e69431 View commit details
    Browse the repository at this point in the history

  28. Fix up e2e creat builder

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e8feae9 View commit details
    Browse the repository at this point in the history

  29. Implement ContstructorReturnType for the storage_ident

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    2265258 View commit details
    Browse the repository at this point in the history

  30. Fmt

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    10d7268 View commit details
    Browse the repository at this point in the history

  31. Fix envaccess test

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    ea65c47 View commit details
    Browse the repository at this point in the history

  32. Fully qualify Result in macro

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    258c27b View commit details
    Browse the repository at this point in the history

  33. More fully qualify Result in macro

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    08dc991 View commit details
    Browse the repository at this point in the history

  34. Fix up build_create examples

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4be979d View commit details
    Browse the repository at this point in the history

  35. Add test for different combos of Self and struct name

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0994c67 View commit details
    Browse the repository at this point in the history

  36. Fix ui test

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    f1f4930 View commit details
    Browse the repository at this point in the history

  37. Fmt

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    12f51dc View commit details
    Browse the repository at this point in the history

  38. Remove unused assoc type

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1bceab3 View commit details
    Browse the repository at this point in the history

  39. Change error fn to return Option<Result>

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    8e0a9ef View commit details
    Browse the repository at this point in the history

  40. Remove commented out code

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    aea1238 View commit details
    Browse the repository at this point in the history

  41. Fmt

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    163fa6b View commit details
    Browse the repository at this point in the history

  42. ConstructorReturnType comments

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1dd00d6 View commit details
    Browse the repository at this point in the history

  43. Fix contract-ref E2E test compilation

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    327967d View commit details
    Browse the repository at this point in the history

  44. Fix up return types after merge

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0bb7a8d View commit details
    Browse the repository at this point in the history

  45. Fmt

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    75ab4e6 View commit details
    Browse the repository at this point in the history

  46. Clippy

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    77a5bab View commit details
    Browse the repository at this point in the history

  47. Fix create_builder tests

    @ascjones @HCastano
    ascjones authored and HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    7d03708 View commit details
    Browse the repository at this point in the history

  48. Fix cross-contract compile test

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    ca47caf View commit details
    Browse the repository at this point in the history

  49. Clean up some comments

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    2cc8a22 View commit details
    Browse the repository at this point in the history

  50. Remove outdated doc

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    fa0436a View commit details
    Browse the repository at this point in the history

  51. Update comment

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    016b102 View commit details
    Browse the repository at this point in the history

  52. Another comment fix

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    9655072 View commit details
    Browse the repository at this point in the history

  53. Wrap long line

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    7aecb5f View commit details
    Browse the repository at this point in the history

  54. Remove TODO

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6f92033 View commit details
    Browse the repository at this point in the history

  55. Bump contract-metadata 

    Fixes some inconsistent errors between Clippy and `rustc`
    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    498c640 View commit details
    Browse the repository at this point in the history

  56. Fix CreateBuilder compilation

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    8e60ec2 View commit details
    Browse the repository at this point in the history

  57. Fix one of the doc tests

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a9c0223 View commit details
    Browse the repository at this point in the history

  58. Clean up doc tests a bit

    @HCastano
    HCastano committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    db1a808 View commit details
    Browse the repository at this point in the history