Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved constants from match to a separate constants #1418

Merged

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Sep 27, 2022

It fixes #1417. It can be used to patch all old releases of ink!.

To reproduce the bug, you need to build any contract with the latest +nightly. The proof that fix works below=)

image

@codecov-commenter
Copy link

Codecov Report

Merging #1418 (cc5a75f) into master (9fe9a42) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
- Coverage   71.97%   71.95%   -0.02%     
==========================================
  Files         187      187              
  Lines        5941     5945       +4     
==========================================
+ Hits         4276     4278       +2     
- Misses       1665     1667       +2     
Impacted Files Coverage Δ
crates/ink/codegen/src/generator/dispatch.rs 94.95% <100.00%> (+0.14%) ⬆️
crates/allocator/src/bump.rs 85.71% <0.00%> (-1.07%) ⬇️
crates/ink/ir/src/ir/attrs.rs 81.99% <0.00%> (-0.28%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@athei
Copy link
Contributor

athei commented Oct 10, 2022

We need to backport to the v3.x.x branch and make a release.

agryaznov added a commit that referenced this pull request Oct 20, 2022
* Add `ink_env::pay_with_call!` helper macro for off-chain emulation of sending payments with contract msg calls (#1379)

* first ver.: transfer_in api function implememted but we can't have it in on-chain env

* transfer_in moved to test_api

* doc + example updated

* Update examples/contract-transfer/lib.rs

Co-authored-by: Hernando Castano <[email protected]>

* use stmt moved to macro

* docs and nitty gritties

* moved the macro to the test mod

* spell fix

* next review round suggestions applied

* Use four spaces for macro indentation

Co-authored-by: Hernando Castano <[email protected]>

* Allow `pay_with_call` to take multiple arguments (#1401)

* Moved constants from `match` to a separate constants (#1418)

* fix tests

Co-authored-by: Hernando Castano <[email protected]>
Co-authored-by: Andrew Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New nightly Rust breaks the building of all contracts with ink!
4 participants