feat: reintroduce upgradable contract examples #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Sep 11, 2023
0xf333
force-pushed
the
0xf333/upgradable_contracts
branch
from
4ab29b7
to
c7ddcf3
Compare
0xf333
force-pushed
the
0xf333/upgradable_contracts
branch
from
c7ddcf3
to
041da1a
Compare
Fixed, |
0xf333
force-pushed
the
0xf333/upgradable_contracts
branch
2 times, most recently
from
f828978
to
b000ffa
Compare
Description
===========
This PR serves two purposes:
- Adjusts ink-examples to align with integration
test repositories.
- Fixes the previous URL check failure from Ink-docs.
For more context, please refer to Ink-docs PR 273.
Impact
======
This PR addresses markdown-link-check issue in Ink-docs:
use-ink/ink-docs#273
* fix: update set-code-hash path in ci
* fix: adjust ci for upgradable-contracts directory
Description
===========
- Added environment variable UPGRADEABLE_CONTRACTS.
- Adjusted ci to process contracts under the
upgradeable-contracts directory.
- Removed unnecessary foo, bar feature flags from the
CI steps as they were not present in Cargo.toml files
0xf333
force-pushed
the
0xf333/upgradable_contracts
branch
from
b000ffa
to
3167ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ascjones
This is about the previous chat regarding the Ink-docs
markdown-link-checkfailure during PRs.Now the link to the upgradable contract will be operational.
Description
This PR serves two purposes:
upgradeable-contractsdirectory.CIsteps as they are not present inCargo.tomlfilesImpact
This PR addresses
markdown-link-checkissue in Ink-docs: use-ink/ink-docs#273.