Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chain logic from extrinsics crate #1568

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Remove chain logic from extrinsics crate #1568

merged 11 commits into from
Apr 4, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Mar 27, 2024 •
edited
Loading

Summary

Related #1554

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependent on the specific version of ink or pallet-contracts?
    Refactored implementation of production chain support

Description

Refactored implementation of production chain support. The main logic has been moved from the extrinsics crate to the cargo-contract crate.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed marked this pull request as ready for review April 4, 2024 08:43
ascjones
ascjones approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a brief description of the changes to the PR description.

@smiasojed smiasojed merged commit 20be25e into master Apr 4, 2024
11 checks passed
@smiasojed smiasojed deleted the sm/fix-1554 branch April 4, 2024 13:36
@tareknaser tareknaser mentioned this pull request Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smiasojed @ascjones