Configure tty output correctly#1209
Merged
Merged
Conversation
pgherveou
approved these changes
Jul 10, 2023
ascjones
reviewed
Jul 10, 2023
Comment on lines
+107
to
+109
| cmd.env("CARGO_TERM_COLOR", "auto") | ||
| .env("CARGO_TERM_PROGRESS_WIDTH", term_size) | ||
| .env("CARGO_TERM_PROGRESS_WHEN", "always") | ||
| .env("CARGO_TERM_PROGRESS_WHEN", "auto") |
Collaborator
There was a problem hiding this comment.
Interesting that this actually works to still correctly detect and display the colour and progress bar, the docs say that the default is auto and yet it does not work when we don't explicitly set it. 🤷
We could go a step further here and pass in the verbosity to this function so that it only sets the TERM_PROGRESS vars when it is not Verbosity::Quiet
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
--output-jsonand--quietflag still produced some compilation status output due to misconfigured tty output. This PR provides a fix.