Enable Wasm sign_ext#1189
Conversation
athei
requested review from
HCastano,
SkymanOne,
ascjones and
cmichi
as code owners
|
Let's keep the PR open until the support comes so we don't break the master |
|
How would we break master? And which master? The development in this repo is blocked unless you downgrade rustc or merge this PR. It doesn't break anything. It keeps working if you use rustc < 1.70 and it didn't work with rustc >= 1.70 before. It just to unblock development here. |
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
LGTM.
Question is, can/should we add validation to check if a sign_ext is produced and provide a warning (not error)? Even once pallet-contracts is updated, it might be that the target chain is still on an old version.
|
Yeah we probably should have a warning. |
|
Added a warning if a new rustc is used. I didn't want to scan for the instructions to not add additional dependencies on |
This reverts commit aa2a2e6.
|
Reverted my CI change because the integration tests fail with |
* Enable Wasm sign_ext * Bump substrate crates * Add warning when building with new rustc * Stable toolchain * Revert "Stable toolchain" This reverts commit aa2a2e6. --------- Co-authored-by: Andrew Jones <ascjones@gmail.com>
* Add `SignextLowering` pass to `wasm-opt` (#1280) * Add `SignextLowering` pass to `wasm-opt` * Remove check for Rust version (cherry picked from commit 756aa38) * Update wasm-opt * Cargo.lock * Enable Wasm sign_ext (#1189) * Enable Wasm sign_ext * Bump substrate crates * Add warning when building with new rustc * Stable toolchain * Revert "Stable toolchain" This reverts commit aa2a2e6. --------- Co-authored-by: Andrew Jones <ascjones@gmail.com> * Cargo.lock * Remove version check * WIP updating subxt * Updating subxt --------- Co-authored-by: Alexander Theißen <alex.theissen@me.com>
3 participants
Fixes #1139
Since Rustc 1.70 we can't disable signed extension anymore. Hence we have to allow it in order to keep functioning. Eventually, we want to remove the
parity-wasmdependency but for now we can just enable thesign_extfeature.Please note that those contracts will not deploy on
pallet-contracts, yet. Support is coming soon.