Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-3185: Yupik Text Fix #1159

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Vote-3185: Yupik Text Fix #1159

merged 1 commit into from
Dec 9, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Dec 9, 2024

Jira ticket

Vote-3185

Description

Addressing bug with Yupik text running past the container

Screenshot 2024-12-09 at 2 57 52 PM Screenshot 2024-12-09 at 2 57 40 PM

Deployment and testing

Post-deploy steps

  1. cd into the votegov theme and run npm run build

QA/Testing instructions

  1. visit home page and change to Yupik translation and verify that test is no longer running past the card.
  2. spot check other translation to check for any regressions

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review December 9, 2024 20:03
@SamiraMSadat SamiraMSadat merged commit 87238fd into dev Dec 9, 2024
2 checks passed
@rayestrada rayestrada deleted the bug/vote-3185-text-overflow branch February 6, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants