Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-3108 resolve regression in nvrf template #1119

Merged
merged 1 commit into from
Nov 19, 2024
Merged

VOTE-3108 resolve regression in nvrf template #1119

merged 1 commit into from
Nov 19, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Nov 19, 2024 •
edited
Loading

Jira ticket

VOTE-3108

Description

Fix regression in NVRF page template

Deployment and testing

Post-deploy steps

  1. lando drush cr

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/register/alabama/mail-in-form-filler and confirm the page loads
  2. visit http://vote-gov.lndo.site/es/registrar/alabama/llenador-de-formulario-por-correo-postal and confirm the page loads

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada merged commit 212897e into stage Nov 19, 2024
2 checks passed
@rayestrada rayestrada deleted the bug/VOTE-3108-nvrf-page-template branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-crowder daniel-crowder daniel-crowder approved these changes

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayestrada @daniel-crowder @SamiraMSadat