Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-3106: Bug fixes for RTL sytles #1099

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Vote-3106: Bug fixes for RTL sytles #1099

merged 7 commits into from
Nov 18, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Nov 8, 2024 •
edited by rayestrada
Loading

Jira ticket

Vote-3106

Description

This Pr will address various style issues with RTL

Banner Issue **live site** Screenshot 2024-11-14 at 9 50 45 PM **fix** Screenshot 2024-11-07 at 4 25 09 PM
Mobile Menu **live site** Screenshot 2024-11-14 at 9 52 17 PM **fix** Screenshot 2024-11-14 at 9 52 46 PM

Mobile issue

  • when visiting the site on mobile and switch to a RTL translation the site was not loading as expected.

Deployment and testing

Post-deploy steps

  1. run lando retune and cd into the votegov theme and run npm run build

QA/Testing instructions

  1. verify that the alert banner for RTL is working as expected
  2. visit the login page and verify that the log in banner is updated as well.
  3. enable mobile view and ensure that you are able to view the site normally in mobile view
  4. while in mobile view verify that in the menu the 2nd item is flipped to match the rest of the menu items

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from rayestrada November 15, 2024 13:44
@clmedders clmedders changed the title Vote-3106: fixing RTL banners - DRAFT Vote-3106: Bug fixes for RTL sytles Nov 18, 2024
@clmedders
Copy link
Contributor Author

@rayestrada here is a full page with all variants of both alerts in EN and AR for reference

Vote Gov Lndo Site Testing Page Nov 18 2024

and

Vote Gov AR Testing Page Screenshot Nov 17 2024

@clmedders clmedders requested a review from rayestrada November 18, 2024 13:40
@rayestrada rayestrada merged commit 8733cac into dev Nov 18, 2024
2 checks passed
tt-gsa added a commit that referenced this pull request Nov 27, 2024
@tt-gsa @clmedders
@SamiraMSadat @rayestrada
Testing/vote 2963 testing (#1137)
beaad4e 
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
@tt-gsa @clmedders
@SamiraMSadat @rayestrada
Testing/vote 2963 testing (#1138)
297600d 
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
@tt-gsa @clmedders
@SamiraMSadat @rayestrada
Testing/vote 2963 testing (#1140)
4cd1a2a 
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
@rayestrada rayestrada deleted the bug/vote-3106-banner-update branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @rayestrada