Add php8 and alpine 3.13 to build matrix #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustingomes
force-pushed
the
agustin/php8
branch
2 times, most recently
from
e84c1fb
to
9e727b3
Compare
WyriHaximus
added a commit
that referenced
this pull request
Feb 22, 2021
During the migration to GitHub Actions in #160 this functionality was mistakenly and overzealously removed. Since PHP 8 and Alpine 3.13 are out and #166 has been filed, currently with a CVE for musl in it, this check should have failed as it is our goal to ship images without known CVE's in it. On my own PHP images the CVE checking fails and as such I was surprised that #166 didn't have any failures. Up on checking the CI logs it showed the musl CVE but the step didn't fail. This commit restores the original functionality and will make the CI once again fail when it finds a CVE in one of the images.
WyriHaximus
added a commit
that referenced
this pull request
Feb 25, 2021
During the migration to GitHub Actions in #160 this functionality was mistakenly and overzealously removed. Since PHP 8 and Alpine 3.13 are out and #166 has been filed, currently with a CVE for musl in it, this check should have failed as it is our goal to ship images without known CVE's in it. On my own PHP images the CVE checking fails and as such I was surprised that #166 didn't have any failures. Up on checking the CI logs it showed the musl CVE but the step didn't fail. This commit restores the original functionality and will make the CI once again fail when it finds a CVE in one of the images.
agustingomes
force-pushed
the
agustin/php8
branch
from
02f757a
to
f9e6d1e
Compare
WyriHaximus
added a commit
that referenced
this pull request
Apr 16, 2021
Even though #166 is in draft and also wants to introduce this. It's IMHO better to do this inclusion in it's own PR.
WyriHaximus
added a commit
that referenced
this pull request
Apr 20, 2021
Even though #166 is in draft and also wants to introduce this. It's IMHO better to do this inclusion in it's own PR.
agustingomes
force-pushed
the
agustin/php8
branch
from
f9e6d1e
to
946e75f
Compare
|
Closing in favour of #179. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usabilla PHP Docker Template
Type
Please specify the type of changes being proposed:
Changelog