resolve golangci-lint cache errors and improve lint output#220
resolve golangci-lint cache errors and improve lint output#220vanshika622 wants to merge 3 commits intourunc-dev:mainfrom
Conversation
vanshika622
commented
Jul 17, 2025
- Replaced built-in golangci-lint caching with manual actions/cache for Go modules and build cache
- Fixed "Cache service responded with 400" and save failures in GitHub Actions
- Updated lint output format to 'github-actions' for better visibility of file-level issues
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ac2081c to
8469f47
Compare
|
Hello @vanshika622 , thank you for the contribution. Changes in the CI from a forked repository require further testing. Please bear with us and we will get back to this PR as soon as possible. |
|
Hi @vanshika622, please rebase your branch over urunc main and we can trigger the CI! |
Signed-off-by: vanshika622 <vanshikajain622@gmail.com>
8469f47 to
4472956
Compare
Done @ananos. I have rebased my branch |
|
thanks @vanshika622! I see an issue with the cache key name. See below:
I think there's a typo: Also, can you please change the name of the cache action to something more meaningful (e.g. Cache or something different than the next step ;-)). Finally, can you please add a short description of what the patch does in the commit message? Just a few words to describe the patch. I'm not entirely sure what thanks! |
Signed-off-by: vanshika622 <vanshikajain622@gmail.com>
I have used this as It acts as a fallback to restore any cache with a matching OS prefix, even if the exact hash key is not available. I have renamed the cache step to Cache Go Modules to make its purpose clearer. and The --out-format=github-actions flag makes linter issues appear inline in the PR, so it’s easier to spot and fix problems directly in the code view. |
|
Hi @vanshika622 , thanks so much for your contribution and for all the changes you made — really appreciate the effort! I was looking through the official documentation for golangci-lint, but I couldn’t find any references to the Would you mind sharing a link to any official documentation or usage examples of this flag? That would help clarify things. Thanks again! |
- Removed deprecated `--out-format=github-actions` flag based on v1.59.0 changelog - Added manual Go module and build caching using actions/cache to fix "Cache service responded with 400" errors - Set `--timeout=5m` to prevent lint step from timing out on large codebases - Enabled all linters and disabled noisy `lll` for better error visibility
Hi @gntouts thank you for pointing this out — really appreciate the feedback! You’re absolutely right: the --out-format=github-actions flag was deprecated in v1.59.0, and I couldn’t find any recent official documentation supporting its usage either. Based on your input, I’ve removed the deprecated flag from the workflow in the latest commit (ea8f996) and instead improved the output by: Thanks again for the review — please let me know if you’d suggest any further improvements! |
|
Hello @vanshika622 , thanks again for your time and effort! I only have one last comment. I think enabling all linters apart from the noisy lll linter is not required in the workflow file, since we already use the |
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
This PR was closed because it has been stalled for 75 days with no activity. |


