infinite loop issues when parsing formating flags#17
Merged
urso merged 1 commit intourso:masterfrom Dec 16, 2019
ph:fix/format-string-memleak-infinite-loop
Merged
infinite loop issues when parsing formating flags#17urso merged 1 commit intourso:masterfrom ph:fix/format-string-memleak-infinite-loop
urso merged 1 commit intourso:masterfrom
ph:fix/format-string-memleak-infinite-loop
Conversation
When the parseFlags was invoked on string that contains a +, the parsing code was entering into an infinite and would keep writing the same string to the buffer until all the memory was consumed.
This was referenced Dec 16, 2019
urso
approved these changes
Dec 16, 2019
ph
added a commit
to elastic/beats
that referenced
this pull request
Dec 17, 2019
This PR add the fix from urso/ecslog#17 Which fix the infinite loop when using parsing flags, the bug was making the library consume all the available memory until the OS killed the process.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This PR add the fix from urso/ecslog#17 Which fix the infinite loop when using parsing flags, the bug was making the library consume all the available memory until the OS killed the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the parseFlags was invoked on string that contains a +, the parsing
code was entering into an infinite and would keep writing the same
string to the buffer until all the memory was consumed.