-
Notifications
You must be signed in to change notification settings - Fork 89
Prepare release 0.9.9 (part of #255) #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @remicollet for php/php-src#18886 |
bd5edf1 to
c990f9e
Compare
fbdc556 to
01443eb
Compare
|
@hartwork I have a last minor request related to my previous comment in this issue: Would it be feasible to add a new From what I see, you are taking great care of ABI compatibility, which makes it easy to update the library version without recompiling PHP. For PHP's phpinfo output it would be useful to have both the version that PHP was compiled against as well as the version actually used (e.g. when a bug is fixed in a future version of the library). See also: php/php-src#19678 |
|
@TimWolla are you aware that because of security backports in distros runtime version information is often not accurate and would need to be read as "that version minimum plus an unknown amount of security fixes on top"? I have rejected a previous request for adding runtime version at #219 (comment) because of that. Simplified it cannot be be relied upon and then what is the value? With that said, does it change the picture for you with PHP? |
|
Yes, I'm aware that distros often backport patches to older versions, but as part of that they generally modify the version number in some way. I would expect the distros to patch the library in a way that this kind of difference is detectable, e.g. by setting |
@TimWolla yes and no: The version of the packaging is bumped, yes, but in many cases the runtime identification remains at the base version despite security fixes.
We're in interesting territory here, because "at least version X" maybe still has more value than no information. Maybe mixing up "exact version" and "minimum version" can be help to some extent. What if we have a function |
@TimWolla alright, let me do the |
8051e8a to
969f26a
Compare
969f26a to
cfb966f
Compare
cfb966f to
73acb77
Compare
|
Thank you! |
|
Thanks! |
|
Glad I could be of help! 🙏 |

Part of #255
CC @kocsismate @TimWolla