Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all App code into Command #1586

Closed
Tracked by #1531
meatballhat opened this issue Nov 15, 2022 · 0 comments · Fixed by #1746
Closed
Tracked by #1531

Consolidate all App code into Command #1586

meatballhat opened this issue Nov 15, 2022 · 0 comments · Fixed by #1746
Assignees
@meatballhat
Labels
area/v3 relates to / is being considered for v3
Milestone
Release 3.x

Comments

@meatballhat
Copy link
Member

meatballhat commented Nov 15, 2022 •
edited
Loading

The App struct and Command struct have very similar surface area and behaviors. Greatly reducing the duplication between them has already been done in the v2 series, but I'd like to see if a single Command struct with .Commands field can be used everywhere and the App struct can be removed (or type alias?).
@meatballhat meatballhat mentioned this issue Nov 15, 2022
Open
21 tasks
@meatballhat meatballhat added this to the Release 3.x milestone Nov 15, 2022
@meatballhat meatballhat mentioned this issue Nov 27, 2022
Closed
6 tasks
@meatballhat meatballhat self-assigned this Nov 28, 2022
meatballhat added a commit that referenced this issue Nov 28, 2022
@meatballhat
Starting to collapse App into Command
b424927 
Connected to #1586
Connected to #1600
@meatballhat meatballhat mentioned this issue Nov 28, 2022
Closed
meatballhat added a commit that referenced this issue Nov 29, 2022
@meatballhat
Starting to collapse App into Command
d7b3bc3 
Connected to #1586
Connected to #1600
meatballhat added a commit that referenced this issue Dec 18, 2022
@meatballhat
Remove NewApp func
7919d3a 
in favor of focusing on declarative API.

Supports #1586
@meatballhat meatballhat mentioned this issue Dec 18, 2022
Merged
meatballhat added a commit that referenced this issue Dec 18, 2022
@meatballhat
Remove Author type
9e40e8e 
and accept strings for Authors instead

Supports #1586
@meatballhat meatballhat mentioned this issue Dec 18, 2022
Closed
meatballhat added a commit that referenced this issue Dec 18, 2022
@meatballhat
Move suggestion-related code to suggestions.go
c4074ac 
Supports #1586
@meatballhat meatballhat mentioned this issue Dec 18, 2022
Merged
meatballhat added a commit that referenced this issue Dec 19, 2022
@meatballhat
Move suggestion-related code to suggestions.go
e8c5cf4 
Supports #1586
meatballhat added a commit that referenced this issue Dec 19, 2022
@meatballhat
Use *mail.Address instead of custom *Author type
6d7ed03 
Supports #1586
@meatballhat meatballhat mentioned this issue Dec 19, 2022
Merged
dearchap pushed a commit to dearchap/cli that referenced this issue Jan 6, 2023
@meatballhat @dearchap
Use *mail.Address instead of custom *Author type
e7a8e35 
Supports urfave#1586
meatballhat added a commit that referenced this issue Jun 2, 2023
@meatballhat
Consolidate all App code into Command
a1149b5 
Closes #1586
@meatballhat meatballhat mentioned this issue Jun 2, 2023
Merged
@dearchap dearchap added the area/v3 relates to / is being considered for v3 label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meatballhat meatballhat

Labels
area/v3 relates to / is being considered for v3
Projects
None yet
Milestone
Release 3.x
2 participants
@meatballhat @dearchap