This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
deduplicates vane interfaces (+note/+sign) #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemfb
force-pushed
the
dedupe-vane-interfaces
branch
from
d6b5119
to
f200138
Compare
| $>(%look task) :: set ethereum source | ||
| == :: | ||
| $: @tas :: | ||
| $% $>(%init vane-task) :: report install |
There was a problem hiding this comment.
this formatting is inconsistent with the rest
| {$this p/? q/clip:eyre r/httq:eyre} :: eyre: in request | ||
| {$thud ~} :: eyre: in cancel | ||
| {$wake ~} :: behn: wakeup | ||
| +$ unix-task :: input from unix |
There was a problem hiding this comment.
It might be nice to define vane interfaces in terms of this, rather than the other way around. That way you could look at a vane interface and immediately see which moves come from Unix. Could be done in a different PR, though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
$>(fixed in #1176) to deduplicate the+note(outgoing "request") and+sign(incoming "response") interfaces of all the vanes, defining these interfaces in terms of the+task(incoming "request") and+gift(outgoing "response") interfaces of other vanes wherever possible.I've also moved all the
+note/+signdefinitions into the vanes themselves -- some were previously in %zuse, but there's no reason for anything but the vanes (and their tests) to reference these.