Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

adds Arvo %warn error notification event handler #1154

Merged
merged 2 commits into from
Apr 25, 2019
Merged

adds Arvo %warn error notification event handler #1154

merged 2 commits into from
Apr 25, 2019

Conversation

joemfb
Copy link
Member

@joemfb joemfb commented Apr 25, 2019

And slightly tweaks %dill's printing of %crud errors. This is the dual of urbit/urbit#1245

Copy link
Contributor

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Also, re: branching, perhaps we can target next for now and I can make a point to get rid of it next week.

@joemfb
Copy link
Member Author

joemfb commented Apr 25, 2019

That's fine with me. It's worth noting that we'll need to do the same branch dance in the urbit/urbit cc-release arvo submodule.

@joemfb joemfb changed the base branch from master to next April 25, 2019 20:04
@joemfb joemfb merged commit 587b4d2 into next Apr 25, 2019
@joemfb joemfb deleted the arvo-warn branch April 25, 2019 20:05
@@ -166,7 +166,7 @@
++ crud
|= {err/@tas tac/(list tank)}
=+ ^= wol ^- wall
:- (trip err)
:- :(weld "%" (trip err) " event failed:")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants