Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

suppresses %clay file-change printfs for initial filesystem #1139

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

joemfb
Copy link
Member

@joemfb joemfb commented Apr 12, 2019

This is not a pressing issue -- consider it a UX feature request.

I've long found these printfs to be superfluous, but it's gotten much worse (imo) with the growth of userspace. This is really highlighted when you boot ships in :aqua.

The printfs are replaced with

clay: committed initial filesystem (hoon)

for base/1, and

clay: committed initial filesystem (all)

for base/2

@joemfb joemfb requested a review from philipcmonk April 12, 2019 06:00
@philipcmonk
Copy link
Contributor

I think this is a good change. lib/ph.hoon uses these printfs to guess when the ship has finished booting, which is why CI is failing. You should be able to just switch the line that searches for "/base/2/web/"... to the new printf.

Copy link
Contributor

@philipcmonk philipcmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"committed"

@joemfb
Copy link
Member Author

joemfb commented Apr 12, 2019

Thanks.

It looks like the %child-sync test hung again, but this time in the "push" build instead of the "pr" build. I don't think that's related to my changes, but it's hard to be sure. Any tips on debugging these?

@joemfb joemfb merged commit 8adbb60 into next Apr 12, 2019
@joemfb joemfb deleted the clay-boot-quiet branch April 12, 2019 20:46
@ixv ixv mentioned this pull request Apr 12, 2019
@joemfb joemfb mentioned this pull request Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants