Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Behn pass errors to client vanes #1135

Merged
merged 7 commits into from
Apr 10, 2019
Merged

Behn pass errors to client vanes #1135

merged 7 commits into from
Apr 10, 2019

Conversation

belisarius222
Copy link
Contributor

This sets the groundwork for future work for vanes to handle async errors. I just added stubs to the various vanes for now, but at least they now have the error information.

A |reset passed, but I have not done more detailed testing on this. Not sure if there's a convenient way to test. Maybe pH?

@belisarius222 belisarius222 changed the base branch from master to next April 9, 2019 00:19
@belisarius222
Copy link
Contributor Author

I resolved a merge conflict in Clay by checking both the error in the %wake move and whether the wire is %tyme.

@belisarius222
Copy link
Contributor Author

Broke :aqua-behn. Fix incoming.

@belisarius222
Copy link
Contributor Author

@philipcmonk I think I fixed Aqua; we'll see what the tests say. I added %crud to +unix-task in Zuse, and I modified :aqua-behn to send one as an aqua-event when it receives a Behn error. If you'd prefer different handling for that case, let me know and I can change it.

@belisarius222
Copy link
Contributor Author

Tests passed; ready for review.

@joemfb
Copy link
Member

joemfb commented Apr 9, 2019

@belisarius222, since this is going into next, do you want to coordinate the %crud protocol change in vere at the same time? I could do that if you'd like.

@belisarius222
Copy link
Contributor Author

@joemfb I'm down, although I think we should get this in as-is first. I think it'll be a little cleaner that way, although I could be convinced otherwise.

Copy link
Contributor

@philipcmonk philipcmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. My only question is whether there are apps that will choke when given an erroring wake. This is still strictly an improvement, though.

@belisarius222 belisarius222 merged commit 20a0a50 into next Apr 10, 2019
@joemfb
Copy link
Member

joemfb commented Apr 10, 2019

It looks to me like all the apps that set timers will fail if the are called with an error %wake. It looks like gall just prints an error in this case, but doesn't crash -- if that's right, %behn will still be unblocked in the event of app timer failure, which is the most important result.

@ixv ixv mentioned this pull request Apr 12, 2019
@jtobin jtobin deleted the time-fault branch April 30, 2019 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants