This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aquarium and pH #1120
Aquarium and pH #1120
Changes from 55 commits
fc9cae6
fe02c76
0757005
88579c5
c6cf690
6138daf
54a6187
ea27465
fd5df26
81e8c59
da5515b
1cfea70
39ce138
705a531
1a87a5c
64b1176
462f027
0fc7ab1
da12f04
17cea6a
600dc02
11adf30
3336699
42d5c90
6337c91
7f8e3da
c3faca0
c4f3614
ad4750f
3e1d742
99b6111
e319df9
3f74d30
e22eac6
55b708d
1ab6fea
68d3ebd
186984f
dab83cd
ae8966e
1e1bcfa
e261983
187aff9
c2c2b04
1893443
3d64641
aba5339
4fc3f63
0dc6e69
e8c7c16
7edcbf7
b5414a4
154a726
8ebe809
3fcd17b
19cb571
98ef8fa
da883a5
04b71f2
73febd4
3c92eb5
7590a4f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little comment explaining that this ignores effects other than %restore or %send might be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be the same
/0v1n.2m9vh
as in the ames handler? Maybe that constant should be split off into sur/aquarium/hoon.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That value is
u3A->sen
, the "instance number" in vere. It's set to(scot %uv (mug now))
on boot/restart. I think the idea is to ensure there's a new duct corresponding to the new process, but it's not used for effect routing (or for injecting%wake
events). I don't think it's needed here. It might not be needed at all, but that's a larger conversation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just cargo-culted that. The right answer is probably for aqua to keep track of that, change it on restart, and insert it into each of these wire as necessary. For now, I've just copied the same string everywhere.