Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Print selected talk audience more compactly #1114

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Print selected talk audience more compactly #1114

merged 1 commit into from
Mar 21, 2019

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Mar 21, 2019

In a multi-target situation: if there is a bound glyph for a target, instead of showing both the glyph and the target, show just the glyph.

So, if I have + bound to ~dopzod/urbit-help, & bound to ~paldev/music, and set my audience with ;+,&, then currently you'll see:

~palfun-foslup:talk[+ ~dopzod/urbit-help & ~paldev/music]

But after this PR, you'll see:

~palfun-foslup:talk[+ &]

If there is a bound glyph for a target, instead of showing both the glyph and
the target, show just the glyph.
@Fang- Fang- added enhancement tweaking or improving existing functionality :hall / :talk labels Mar 21, 2019
@Fang- Fang- requested a review from ixv March 21, 2019 11:57
@Fang- Fang- changed the base branch from master to hotfix March 21, 2019 13:43
Copy link
Contributor

@ixv ixv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fang- Fang- merged commit 965b140 into hotfix Mar 21, 2019
@Fang- Fang- deleted the talk-prompt branch March 21, 2019 17:38
@ixv ixv mentioned this pull request Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement tweaking or improving existing functionality :hall / :talk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants