Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

added ++arm:core, +-arm:core, +$arm:core, +*arm:core to udon parser #1096

Merged
merged 2 commits into from
May 8, 2019

Conversation

jfranklin9000
Copy link
Contributor

Before:

++arm
+-arm
+$arm
+*arm

++arm:core
+-arm:core
+$arm:core
+*arm:core

After:

++arm
+-arm
+$arm
+*arm

++arm:core
+-arm:core
+$arm:core
+*arm:core

This has PR #1091 functionality in it (parsing :core) and can replace it.

Should this be submitted against next instead of master?

@Fang- Fang- changed the base branch from master to next March 6, 2019 23:27
@Fang- Fang- requested a review from pilfer-pandex March 6, 2019 23:27
@Fang- Fang- added enhancement tweaking or improving existing functionality udon udon, the hoon .md syntax labels Mar 6, 2019
@jfranklin9000
Copy link
Contributor Author

Without this patch

[++abs`:fl`](../library/3b/#--abs-fl-)

from docs/reference/alphabetical-arms.udon displays split:
split

If this patch is accepted I'll submit a patch to docs that does

[++abs:fl](../library/3b/#--abs-fl-)

It not I'll submit a patch to docs that does

[`++abs:fl`](../library/3b/#--abs-fl-)

@joemfb
Copy link
Member

joemfb commented May 7, 2019

bumping for @pilfer-pandex

Copy link
Contributor

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The looks good to me; the example @jfranklin9000 pointed at is now at docs/reference/library.udon, where the splits have since been handled by tics (possibly also contributed by @jfranklin9000 himself). This obviates the need to use tics at all.

@jtobin jtobin changed the base branch from next to master May 8, 2019 12:58
@jtobin
Copy link
Contributor

jtobin commented May 8, 2019

(We're deprecating next and friends, so I've changed the base to master.)

@jtobin
Copy link
Contributor

jtobin commented May 8, 2019

I'll give @pilfer-pandex a chance to review, but absent any complaints I'll merge this one tomorrow.

Copy link
Contributor

@pilfer-pandex pilfer-pandex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtobin jtobin merged commit 8018745 into urbit:master May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement tweaking or improving existing functionality udon udon, the hoon .md syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants