Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redefine identity #320

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Avoid redefine identity #320

merged 3 commits into from
Dec 13, 2024

Conversation

MVitelli
Copy link
Contributor

@MVitelli MVitelli commented Dec 1, 2024

fix #298

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (9e8acd6) to head (a521153).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   89.73%   89.74%           
=======================================
  Files          28       28           
  Lines        3176     3178    +2     
  Branches      576      577    +1     
=======================================
+ Hits         2850     2852    +2     
  Misses        170      170           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fdodino fdodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 puntos

src/validator/index.ts Show resolved Hide resolved
}, [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acá lo mismo, es un rompe el linter, hay que sacarle el ENTER al final del archivo

@fdodino fdodino merged commit f96dd12 into master Dec 13, 2024
4 checks passed
@fdodino fdodino deleted the avoid-redefine-identity branch December 13, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Se puede redefinir el ===
3 participants