Tests for errors on game events #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 89.68% 89.74% +0.06%
==========================================
Files 26 26
Lines 2849 2848 -1
Branches 500 500
==========================================
+ Hits 2555 2556 +1
+ Misses 157 155 -2
Partials 137 137 ☔ View full report in Codecov by Sentry. |
|
Ahí la heackié para que el CI corra contra master de language. Creo que esto nos hace un toque más felices 🎂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests para este PR: uqbar-project/wollok-language#183
Moví el error reporter como una property en Language, ya que la lógica estaba allá (además confío que no afecta en la performance).
Además aproveché para sacar tests que ya se movieron como sanity 🧹
Hay que releasear Language para que pase el CI 😢