Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #86 implementacion de floor #210

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix #86 implementacion de floor #210

merged 2 commits into from
Oct 8, 2024

Conversation

rodriguez-guillermo
Copy link
Contributor

No description provided.

@rodriguez-guillermo
Copy link
Contributor Author

It was implemented method floor() with their respective tests.

@fdodino
Copy link
Contributor

fdodino commented Oct 5, 2024

Excelente @rodriguez-guillermo !!!

Bienvenido a Wollok!! Ahora te propongo que le agregues ceiling() y round() sin parámetros al PR. Si necesitás ayuda chiflame y lo vamos viendo con tiempo.

PalumboN
PalumboN approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vamooooo!! 🚀🚀

@fdodino fdodino merged commit 22ba1c1 into master Oct 8, 2024
@fdodino fdodino deleted the fix-#86-implementacion-de-floor branch October 8, 2024 20:59
@fdodino fdodino mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PalumboN PalumboN PalumboN approved these changes

@fdodino fdodino Awaiting requested review from fdodino

@ivojawer ivojawer Awaiting requested review from ivojawer

@asanzo asanzo Awaiting requested review from asanzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodriguez-guillermo @fdodino @PalumboN