Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #139 #205

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Fix #139 #205

merged 4 commits into from
Oct 8, 2024

Conversation

fdodino
Copy link
Contributor

@fdodino fdodino commented Oct 3, 2024

Migramos los mensajes del validador a un JSON. Eso resuelve

@fdodino fdodino marked this pull request as ready for review October 6, 2024 13:19
Copy link
Contributor

@ivojawer ivojawer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hermoso! 📖

Un comentario de estilos nomas, siempre que vi estos diccionarios implementados la estructura de carpetas queda algo asi como:

src/resources/validation-messages/
├── en.json
└── es.json

Igual da lo mismo porque esto se va a exponer a travez de wollok-ts 🤷

@fdodino
Copy link
Contributor Author

fdodino commented Oct 6, 2024

Hermoso! 📖

Un comentario de estilos nomas, siempre que vi estos diccionarios implementados la estructura de carpetas queda algo asi como:

src/resources/validation-messages/
├── en.json
└── es.json

Igual da lo mismo porque esto se va a exponer a travez de wollok-ts 🤷

Joya, hablamos el martes si querés. A mí medio que me da lo mismo, lo que sí me queda pendiente es explicar cómo se define y cómo se usan los json en la implementación de ts.

Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oohh @fdodino , usted sabe cómo hacer feliz a un rasta 😌✨

Agree a lo que dice el Ivo. Igual son detalles (mi comment también).

Lo definimos mañana en la reunión!

@@ -0,0 +1,59 @@
{
"nameShouldBeginWithLowercase": "The name {0} must start with lowercase",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estaría piola que estos archivos estén ordenados alfabéticamente (algo que se puede chatgptear la primera vez)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahí subo una versión ordenadilla

@fdodino fdodino merged commit 4192701 into master Oct 8, 2024
@fdodino fdodino deleted the migrate-validation-messages branch October 8, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants