-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #139 #205
Fix #139 #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hermoso! 📖
Un comentario de estilos nomas, siempre que vi estos diccionarios implementados la estructura de carpetas queda algo asi como:
src/resources/validation-messages/
├── en.json
└── es.json
Igual da lo mismo porque esto se va a exponer a travez de wollok-ts 🤷
Joya, hablamos el martes si querés. A mí medio que me da lo mismo, lo que sí me queda pendiente es explicar cómo se define y cómo se usan los json en la implementación de ts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oohh @fdodino , usted sabe cómo hacer feliz a un rasta 😌✨
Agree a lo que dice el Ivo. Igual son detalles (mi comment también).
Lo definimos mañana en la reunión!
@@ -0,0 +1,59 @@ | |||
{ | |||
"nameShouldBeginWithLowercase": "The name {0} must start with lowercase", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Estaría piola que estos archivos estén ordenados alfabéticamente (algo que se puede chatgptear la primera vez)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahí subo una versión ordenadilla
…t/wollok-language into migrate-validation-messages
Migramos los mensajes del validador a un JSON. Eso resuelve