Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agregado de expectedOn para los tests #168

Merged
merged 61 commits into from
Dec 18, 2023
Merged

Agregado de expectedOn para los tests #168

merged 61 commits into from
Dec 18, 2023

Conversation

fdodino
Copy link
Contributor

@fdodino fdodino commented Dec 6, 2023

Ahora los tests del validador aceptan dentro de la anotación Expected el atributo expectedOn para circunscribir dónde debería marcarse el error. Ejemplo:

@Expect(code="nameShouldBeginWithLowercase", level="warning", expectedOn="SomeObject")
object SomeObject {}

fdodino added 30 commits December 5, 2023 21:40
@fdodino
add expectedOn for shouldNotDefineUnusedVariables
6c94b83
@fdodino
Add expectedOn for nameShouldBeginWithLowercase
d3610ad
@fdodino
Adding expectedOn
4f9c856
@fdodino
shouldNotDuplicateLocalVariables
6c5b3f9
@fdodino
Add shouldNotDuplicateGlobalDefinitions
d28816e
@fdodino
Add expectedOn for shouldNotDuplicateGlobalDefinitions
b2c2835
@fdodino
inlineSingletonShouldBeAnonymous
4c44efb
@fdodino
Add expected on for methodShouldExist
aeb48f8
@fdodino
add expected on for certain cases of missingReference
6b34417
@fdodino
expectedOn for named arguments
eecccf2
@fdodino
add expected on for nameShouldBeginWithUppercase
6fe15c5
@fdodino
add expected on to overridingMethodShouldHaveABody
314122c
@fdodino
add expected on to parameterShouldNotDuplicateExistingVariable
18dcd71
@fdodino
add expected on for shouldDefineConstInsteadOfVar
9036a0c
@fdodino
expected on for shouldHaveDifferentName
ab12f04
@fdodino
add expected on for shouldHaveNonEmptyName
4e652d5
@fdodino
add expected on for shouldInitializeConst
e15fd04
@fdodino
add expected on for shouldInitializeGlobalReference
1b4a588
@fdodino
add expected on for shouldInitializeSingletonAttribute
f653e62
@fdodino
add expected on to shouldNotAssignToItself
0ad68c5
@fdodino
add expectedOn to shouldNotCompareEqualityOfSingleton
8bb5a09
@fdodino
add expectedOn to shouldNotDefineGlobalMutableVariables
3e7f0ad
@fdodino
add expectedOn to shouldNotDefineNativeMethodsOnUnnamedSingleton
84b4f69
@fdodino
add expectedOn for shouldNotDuplicateEntities
dd7b9dc
@fdodino
add expectedOn to shouldNotDuplicateFields
f30eb2a
@fdodino
add expectedOn to shouldNotDuplicatePackageName
b4fdf77
@fdodino
add expectedOn for shouldNotInstantiateAbstractClass
a88e812
@fdodino
add expectedOn for shouldNotMarkMoreThanOneOnlyTest
80a7f44
@fdodino
add expectedOn to shouldNotMarkMoreThanOneOnlyTest
fa08f6f
@fdodino
add expectedOn to shouldNotReassignConst
24f4969
fdodino added 22 commits December 8, 2023 00:27
@fdodino
add expectedON for topLevelSingletonShouldHaveAName
7dbea58
@fdodino
Changed scope of shouldNotReassignConst expectedOn value
8e484ba
@fdodino
add expectedOn for shouldNotDefineUnnecesaryIf
b11044e
@fdodino
add expectedOn for getterMethodShouldReturnAValue
509ea73
@fdodino
add expectedOn for shouldHaveBody
b9f9b50
@fdodino
add expectedOn for codeShouldBeReachable
23e127a
@fdodino
Fix typo: value -> level
23a8e35
@fdodino
add expectedOn for possiblyReturningBlock
1472f85
@fdodino
add expectedOn for shouldHaveAssertInTest
b45ab13
@fdodino
add expectedOn for shouldMatchSuperclassReturnValue + shouldHaveCatch…
9f41a16 
…OrAlways
@fdodino
add expectedOn for shouldNotCompareAgainstBooleanLiterals
bdd763e
@fdodino
add expectedOn for shouldNotDefineEmptyDescribe
185070d
@fdodino
add expectedOn for shouldNotDefineUnnecessaryCondition
a99721b
@fdodino
add expectedOn for shouldNotDuplicateVariablesInLinearization
f3904f8
@fdodino
add expectedOn for shouldNotImportMoreThanOnce
01a5be5
@fdodino
shouldNotImportSameFile
a111c25
@fdodino
Fix shouldMatchSuperclassReturnValue and add expectedOn shouldNotOnly…
2587bf0 
…CallToSuper
@fdodino
shouldNotUseVoidMethodAsValue
80d1640
@fdodino
add expectedOn for shouldOnlyInheritFromMixin
6aa797b
@fdodino
add expectedOn for shouldPassValuesToAllAttributes
7a44ad0
@fdodino
add expectedOn for shouldReturnAValueOnAllFlows
4a529fe
@fdodino
Fix whitespaces for validations in most of the files
7769f64
@fdodino fdodino mentioned this pull request Dec 12, 2023
Open
@fdodino fdodino marked this pull request as ready for review December 12, 2023 22:37
PalumboN
PalumboN approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LA BU RA ZO 🔥 💯 😀

@fdodino fdodino merged commit 58e0913 into master Dec 18, 2023
@fdodino fdodino deleted the fix-#170-unused-variable-source-map branch December 18, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PalumboN PalumboN PalumboN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdodino @PalumboN