Cambios sintaxis variables repetidas #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FerRomMu
commented
Sep 1, 2022
nscarcella
reviewed
Sep 7, 2022
PalumboN
reviewed
Oct 23, 2022
|
@PalumboN , este PR está viejardo, yo lo cerraría salvo que te parezca pulirlo y mergearlo. |
|
@fdodino no sé, para mí está más para mergear, no hace ningún cambio muy loco |
PalumboN
approved these changes
Dec 3, 2023
|
Mergea2! Gracias @FerRomMu ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En este pr tengo principalmente cambios por el warn de: shouldNotDuplicateLocalVariables
Al cambiar el nombre de las variables locales no estoy seguro de si no estoy afectando el objetivo del test. ¿Hay alguna razón para que el nombre se repitiera?Por ej, ¿Se busca ver cual es la referencia a un par que se toma o solo se esta testeando los pares? Entiendo que no es el caso y que por lo tanto se pueden renombrar esas variables.
Tambien hay uno por: shouldNotCompareEqualityOfSingleton . Este me deja ciertas dudas. La manera en que lo solucioné fue asignandolo a una constante. Entiendo que eso no debería dañar la naturaleza del test visto que el ciclo de referencias infinitas debería seguir.