Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check update value against state not props to allow initial value set #62

Merged
merged 2 commits into from
Jul 23, 2018

Conversation

tabby-or-not
Copy link
Contributor

Value was not being updated from the initial mount

@tabby-or-not tabby-or-not added the bug Something isn't working label Jul 23, 2018
@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          60       60           
  Lines         600      600           
  Branches      133      133           
=======================================
  Hits          584      584           
  Misses         13       13           
  Partials        3        3
Impacted Files Coverage Δ
src/filters/types/Choice.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe7aae...a1fbc06. Read the comment docs.

@tabby-or-not tabby-or-not merged commit 874747a into master Jul 23, 2018
@tabby-or-not tabby-or-not deleted the hotfix/choice-value branch July 23, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant