Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker build args #22

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Add docker build args #22

merged 6 commits into from
Nov 28, 2024

Conversation

mdesouky
Copy link
Collaborator

@mdesouky mdesouky commented Nov 28, 2024 •
edited
Loading

Changes:

uptickmetachu
uptickmetachu approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@uptickmetachu uptickmetachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need a pre commit hook yaml formatter in this repo anda vscode setting..

@mdesouky
Copy link
Collaborator Author

We might need a pre commit hook yaml formatter in this repo anda vscode setting..

@uptickmetachu great idea, will make that happen!

@mdesouky mdesouky merged commit 27efd86 into main Nov 28, 2024
7 checks passed
@mdesouky mdesouky deleted the dev-956/fix-logbooks-docker-build branch November 28, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uptickmetachu uptickmetachu uptickmetachu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdesouky @uptickmetachu