Push images to both management account and deployments account #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdesouky
requested review from
uptickmetachu
and removed request for
uptickmetachu
|
Can we squash all the commits after we've done our testing? |
sure |
| @@ -385,7 +390,9 @@ jobs: | |||
| platforms: ${{inputs.docker-image-platforms}} | |||
| push: true | |||
| # Default to just the git short hash. if docker-tag-latest ; also tag as the latest image | |||
| tags: ${{inputs.docker-repository}}:${{inputs.docker-prefix && format('{0}-', inputs.docker-prefix) || ''}}${{env.GIT_SHORT_HASH}}${{inputs.docker-tag-latest && format(',{0}:latest',inputs.docker-repository)|| ''}}${{inputs.docker-tag && format(',{0}:{1}',inputs.docker-repository, inputs.docker-tag)|| ''}} | |||
| tags: | | |||
| ${{ format('{0}:{1}{2}{3}{4}', inputs.docker-repository, inputs.docker-prefix && format('{0}-', inputs.docker-prefix) || '', env.GIT_SHORT_HASH, inputs.docker-tag-latest && format(',{0}:latest', inputs.docker-repository) || '', inputs.docker-tag && format(',{0}:{1}', inputs.docker-repository, inputs.docker-tag) || '') }} | |||
There was a problem hiding this comment.
I'm going to need comments to show ht eexample output
There was a problem hiding this comment.
This is a bit of a maintenance night mare in the future but If it works it works.
Ideally we have a step to write this out cleanly via python etc but I won't block on that since if we don't need to touch it its not bad.
Can we leave a TODO comment to refactor this in the future into a script.
mdesouky
force-pushed
the
dev-878/modify-ci-workflow-to-push-docker-images-to-two-repos
branch
from
0d99ec6 to
d920a54
Compare
uptickmetachu
approved these changes
Oct 22, 2024
mdesouky
deleted the
dev-878/modify-ci-workflow-to-push-docker-images-to-two-repos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: