Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Fields in Requests & Add DLQ Filtering and Batch Cancel API #114

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

CahidArda
Copy link
Contributor

@CahidArda CahidArda commented Jun 26, 2024

Updating Qstash JS with the recent updates to backend.

This pr includes the following changes as @mdumandag listed:

  1. 1e6e690: message type has missing fields (like endpoint, api, caller ip, bodyBase64 etc.)
  2. bc1c164: dlq message type has missing fields (like response status, response headers etc.)
  3. d4fc931: dlq list method missing filter and count (the python client has a pending pr for it) Add support for filtering DLQ messages qstash-py#21
  4. 60e89d5: event filter missing api field
  5. 5c01b1c: event list response missing some fields (like api, queue name, schedule id, and fields in this
  6. d0f588f: scheduele type missing fields (like bodyBase64 and caller ip)
  7. dd93920: missing batch cancel apis (the python client has a pending pr for it) Add bulk cancel APIs qstash-py#22

@CahidArda CahidArda changed the title Hotfix qstash missing features Add Missing Fields in Requests & Add DLQ Filtering and Batch Cancel API Jun 27, 2024
@mdumandag
Copy link

We might do some changes in the cancelAll API in the qstash server, so let's not merge this (or merge, but not release) for now. I will let you know when the changes are finalized&deployed

@mdumandag
Copy link

@CahidArda we can merge the PR with the current api for the batch cancel, we decided to proceed with the current state on the qstash server

@CahidArda CahidArda merged commit d82f064 into main Jul 2, 2024
3 checks passed
CahidArda added a commit to upstash/docs that referenced this pull request Jul 16, 2024
mdogan pushed a commit to upstash/docs that referenced this pull request Jul 19, 2024
* feat: add pause resume schedule & queue docs and timeout docs

the changes reflect the last two changes in upstash/qstash-js#109

* feat: add qstash-js messages deleteMany & deletAll examples

the changes we document are in:
- PR upstash/qstash-js#114
- commit upstash/qstash-js@dd93920

* fix: update according to reviews
@CahidArda CahidArda deleted the hotfix-qstash-missing-features branch September 9, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants