Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QStash Python SDK docs #194

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Update QStash Python SDK docs #194

merged 3 commits into from
Jul 19, 2024

Conversation

mdumandag
Copy link
Contributor

We have rewritten the SDK, so this PR updates the places where we gave SDK code snippets for it.

It should be merged after we release the new version of the SDK.

@mdumandag mdumandag requested a review from CahidArda June 12, 2024 11:56
@CahidArda
Copy link
Contributor

CahidArda commented Jun 14, 2024

@mdumandag
Copy link
Contributor Author

Let's leave that to a later, when we update the UI etc. I intentionally didn't change any other part than the Python related parts where we renamed topic to url group.

@CahidArda
Copy link
Contributor

CahidArda commented Jun 26, 2024

Let's leave that to a later, when we update the UI etc. I intentionally didn't change any other part than the Python related parts where we renamed topic to url group.

we updated the console btw, qstash-js is also updated.

we should update docs/examples to use url group instead of topic. I can handle this

@mdogan mdogan marked this pull request as ready for review July 5, 2024 08:30
@mdogan mdogan marked this pull request as draft July 5, 2024 08:31
@CahidArda
Copy link
Contributor

I have completed the changes in Qstash and Qstash JS.

there are already too many changes in this PR, I feel like we can go ahead with this PR and complete rest of the topic -> URL group changes in another PR.

We have rewritten the SDK, so this PR updates the places where
we gave SDK code snippets for it.

It should be merged after we release the new version of the SDK.
@mdumandag mdumandag force-pushed the qstash-python-doc-update branch from 0b17486 to fbbac24 Compare July 18, 2024 12:44
@CahidArda CahidArda marked this pull request as ready for review July 18, 2024 16:42
@mdogan mdogan merged commit 374169c into main Jul 19, 2024
@mdogan mdogan deleted the qstash-python-doc-update branch July 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants