Merge pull request #12 from piouslove/piouslove

sig `nonce` should use `identityOwner(identity)` instead of just `identity`
uport-project · Sep 20, 2018 · f4e17ee · f4e17ee
2 parents af09087 + 20e40f0
commit f4e17ee
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/contracts/EthereumDIDRegistry.sol b/contracts/EthereumDIDRegistry.sol
@@ -45,7 +45,7 @@ contract EthereumDIDRegistry {
   function checkSignature(address identity, uint8 sigV, bytes32 sigR, bytes32 sigS, bytes32 hash) internal returns(address) {
     address signer = ecrecover(hash, sigV, sigR, sigS);
     require(signer == identityOwner(identity));
-    nonce[identity]++;
+    nonce[signer]++;
     return signer;
   }
 
@@ -109,7 +109,7 @@ contract EthereumDIDRegistry {
   }
 
   function setAttributeSigned(address identity, uint8 sigV, bytes32 sigR, bytes32 sigS, bytes32 name, bytes value, uint validity) public {
-    bytes32 hash = keccak256(byte(0x19), byte(0), this, nonce[identity], identity, "setAttribute", name, value, validity);
+    bytes32 hash = keccak256(byte(0x19), byte(0), this, nonce[identityOwner(identity)], identity, "setAttribute", name, value, validity);
     setAttribute(identity, checkSignature(identity, sigV, sigR, sigS, hash), name, value, validity);
   }
 
@@ -123,7 +123,7 @@ contract EthereumDIDRegistry {
   }
 
  function revokeAttributeSigned(address identity, uint8 sigV, bytes32 sigR, bytes32 sigS, bytes32 name, bytes value) public {
-    bytes32 hash = keccak256(byte(0x19), byte(0), this, nonce[identity], identity, "revokeAttribute", name, value); 
+    bytes32 hash = keccak256(byte(0x19), byte(0), this, nonce[identityOwner(identity)], identity, "revokeAttribute", name, value); 
     revokeAttribute(identity, checkSignature(identity, sigV, sigR, sigS, hash), name, value);
   }