fix(block): destroy both local and global contexts

uploadcare · Dec 1, 2023 · bdd4a33 · bdd4a33
1 parent 362fea9
commit bdd4a33
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/abstract/Block.js b/abstract/Block.js
@@ -1,5 +1,5 @@
 // @ts-check
-import { BaseComponent } from '@symbiotejs/symbiote';
+import { BaseComponent, Data } from '@symbiotejs/symbiote';
 import { EventEmitter } from '../blocks/UploadCtxProvider/EventEmitter.js';
 import { createWindowHeightTracker, getIsWindowHeightTracked } from '../utils/createWindowHeightTracker.js';
 import { getPluralForm } from '../utils/getPluralForm.js';
@@ -188,8 +188,18 @@ export class Block extends BaseComponent {
   }
 
   destroyCallback() {
+    /** @type {Set<Block>} */
     let blocksRegistry = this.$['*blocksRegistry'];
     blocksRegistry.delete(this);
+
+    // Destroy local context
+    // TODO: this should be done inside symbiote
+    Data.deleteCtx(this);
+
+    if (blocksRegistry.size === 0) {
+      // Destroy external context if there is no any blocks left inside it
+      Data.deleteCtx(this.ctxName);
+    }
   }
 
   /**