Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty response bodies #31

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Conversation

diogoguimaraes
Copy link
Contributor

This pull request adds support for responses with not nil bodies with empty strings.

@diogoguimaraes diogoguimaraes self-assigned this Feb 18, 2016
@diogoguimaraes diogoguimaraes force-pushed the support/empty-response-body branch from 4bca2c2 to 36b93ac Compare February 18, 2016 18:50
@diogoguimaraes
Copy link
Contributor Author

R=@SandroMachado

@@ -53,7 +59,7 @@ public class UpholdRestAdapter {

reject(LogicError(code: nil, message: "Response body should be empty."))
}, onError: { (error: NSError) -> Void in
reject(error)
return error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change.

@diogoguimaraes diogoguimaraes force-pushed the support/empty-response-body branch from 36b93ac to ba2a97c Compare February 22, 2016 10:28
@diogoguimaraes
Copy link
Contributor Author

Updated @SandroMachado.

@diogoguimaraes diogoguimaraes force-pushed the support/empty-response-body branch from ba2a97c to 916f8d9 Compare February 22, 2016 11:57
SandroMachado added a commit that referenced this pull request Feb 22, 2016
@SandroMachado SandroMachado merged commit 34fa81a into master Feb 22, 2016
@SandroMachado SandroMachado deleted the support/empty-response-body branch February 22, 2016 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants