Update transaction model #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
from
1c49382 to
0deab81
Compare
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
from
0deab81 to
59808cd
Compare
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
2 times, most recently
from
8ccabd3 to
4119497
Compare
| return Promise<Transaction>(error: UnexpectedResponseError(message: "Transaction id should not be nil.")) | ||
| } | ||
|
|
||
| guard let origin = self.origin, cardId = origin.cardId else { |
There was a problem hiding this comment.
Change to guard let cardId = self.origin?.cardId else. Our objective is to extract only the cardId, so we don't need to unwrap the origin to unwrap the cardId.
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
from
4119497 to
a219658
Compare
|
Updated @SandroMachado. |
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
from
a219658 to
5a5eaf5
Compare
| /** | ||
| Creates a transaction. | ||
|
|
||
| - parameter transactionRequest: The transaction request information. |
There was a problem hiding this comment.
Fix the documentation.
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
from
5a5eaf5 to
606c94e
Compare
| @@ -115,20 +115,20 @@ class CardTest: UpholdTestCase { | |||
|
|
|||
| card.createTransaction(transactionRequest).then { (transaction: Transaction) -> () in | |||
There was a problem hiding this comment.
- Add a test to the create transaction with commit query parameter.
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
from
606c94e to
736c412
Compare
| let request = UserCardService.createTransaction("bar", commit: true, transactionRequest: "foobar") | ||
|
|
||
| XCTAssertEqual(request.url, "https://api.uphold.com/v0/me/cards/bar/transactions", "Failed: Wrong URL.") | ||
| XCTAssertEqual(request.query[0], "commit=true", "Failed: Wrong URL.") |
There was a problem hiding this comment.
Please add an assert to the size of the query parameters.
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
from
736c412 to
ead5eb0
Compare
|
Updated @SandroMachado. |
| func testCreateTransactionWithCommitShouldReturnTheTransaction() { | ||
| let card: Card = Fixtures.loadCard(nil) | ||
| let expectation = expectationWithDescription("Card test: create transaction.") | ||
| card.adapter = MockRestAdapter(body: "{ \"id\": \"foobar\" }") |
diogoguimaraes
force-pushed
the
feature/update-transaction
branch
from
ead5eb0 to
be69a4e
Compare
SandroMachado
added a commit
that referenced
this pull request
Dec 11, 2015
Update transaction model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the transaction model.