-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user model #19
Conversation
9dbbda3
to
72cf712
Compare
6f7ddab
to
49ef145
Compare
/// Balance model. | ||
public class Balance: Mappable { | ||
|
||
public private(set) var balances: UserBalance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the DocBlock.
} | ||
}) | ||
|
||
if (filteredCards.count == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace by filteredCards.isEmpty
.
78883cc
to
d354331
Compare
// MARK: Required by the ObjectMapper. | ||
|
||
/** | ||
Constructor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a whitespace.
d354331
to
ce37cb4
Compare
let done = { (response: Response) -> Void in | ||
let error = UnexpectedResponseError(message: "foo") | ||
|
||
XCTAssertNil(error.code, "Failed: Wrong response HTTP status code.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve the message.
bb2a714
to
436851b
Compare
XCTAssertEqual(contact[0].id, "foobar", "Failed: Wrong contact object.") | ||
XCTAssertEqual(contact[0].lastName, "Bar", "Failed: Wrong contact object.") | ||
XCTAssertEqual(contact[0].name, "Foo Bar", "Failed: Wrong contact object.") | ||
XCTAssertEqual(contact[1].addresses![0], "FizBiz FooBiz", "Failed: Wrong contact object.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an assert to the size of the addresses.
436851b
to
dc75650
Compare
self.expectation.fulfill() | ||
} | ||
|
||
MockRequest(body: "body", code: 200, errorHandler: {(error: NSError) -> Void in}, headers: nil, method: "foo").end(done, onError: self.defaultError) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a whitespace before and after the {
.
dc75650
to
215c05b
Compare
This pull request updates the user model.