Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user model #19

Merged
merged 3 commits into from
Dec 2, 2015
Merged

Update user model #19

merged 3 commits into from
Dec 2, 2015

Conversation

diogoguimaraes
Copy link
Contributor

This pull request updates the user model.

@diogoguimaraes diogoguimaraes self-assigned this Nov 25, 2015
@diogoguimaraes diogoguimaraes force-pushed the feature/add-user branch 2 times, most recently from 9dbbda3 to 72cf712 Compare November 25, 2015 16:01
@diogoguimaraes diogoguimaraes changed the title Add user Add user model Nov 25, 2015
@diogoguimaraes diogoguimaraes force-pushed the feature/add-user branch 2 times, most recently from 6f7ddab to 49ef145 Compare November 25, 2015 16:25
@diogoguimaraes diogoguimaraes changed the title Add user model Update user model Nov 25, 2015
@diogoguimaraes
Copy link
Contributor Author

R=@SandroMachado.

/// Balance model.
public class Balance: Mappable {

public private(set) var balances: UserBalance?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the DocBlock.

}
})

if (filteredCards.count == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace by filteredCards.isEmpty.

@diogoguimaraes diogoguimaraes force-pushed the feature/add-user branch 4 times, most recently from 78883cc to d354331 Compare December 2, 2015 16:55
// MARK: Required by the ObjectMapper.

/**
Constructor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a whitespace.

let done = { (response: Response) -> Void in
let error = UnexpectedResponseError(message: "foo")

XCTAssertNil(error.code, "Failed: Wrong response HTTP status code.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the message.

@diogoguimaraes diogoguimaraes force-pushed the feature/add-user branch 5 times, most recently from bb2a714 to 436851b Compare December 2, 2015 18:23
XCTAssertEqual(contact[0].id, "foobar", "Failed: Wrong contact object.")
XCTAssertEqual(contact[0].lastName, "Bar", "Failed: Wrong contact object.")
XCTAssertEqual(contact[0].name, "Foo Bar", "Failed: Wrong contact object.")
XCTAssertEqual(contact[1].addresses![0], "FizBiz FooBiz", "Failed: Wrong contact object.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an assert to the size of the addresses.

self.expectation.fulfill()
}

MockRequest(body: "body", code: 200, errorHandler: {(error: NSError) -> Void in}, headers: nil, method: "foo").end(done, onError: self.defaultError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a whitespace before and after the {.

SandroMachado added a commit that referenced this pull request Dec 2, 2015
@SandroMachado SandroMachado merged commit 0ee7028 into master Dec 2, 2015
@SandroMachado SandroMachado deleted the feature/add-user branch December 2, 2015 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants