Add reserve model #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
2 times, most recently
from
c303043 to
73bad8b
Compare
| } | ||
|
|
||
| /** | ||
| Gets the public view of any transaction. |
There was a problem hiding this comment.
Change to Gets the information of any transaction.?
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
from
73bad8b to
aefffa0
Compare
|
|
||
| - parameter type: The type of the deposit. | ||
| - parameter out: The deposit out movement. | ||
| - parameter `in`: The deposit in movement. |
There was a problem hiding this comment.
Can we remove the backticks from the in parameter in the documentation.
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
from
aefffa0 to
3524145
Compare
| reserve.adapter = MockRestAdapter(body: json) | ||
|
|
||
| reserve.getStatistics().then { (statistics: [ReserveStatistics]) -> () in | ||
| XCTAssertEqual(statistics[0].currency, "FOO", "Failed: Currency didn't match.") |
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
from
3524145 to
9c8363a
Compare
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
from
9c8363a to
ca3ffff
Compare
| "\"assets\": \"foobar\"," + | ||
| "\"liabilities\": \"foobiz\"" + | ||
| "}" + | ||
| "}, {" + |
There was a problem hiding this comment.
Please fix the indentation.
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
from
ca3ffff to
60d83ed
Compare
| - parameter transactionId: The id of the transaction. | ||
| - parameter type: The type of the deposit. | ||
| */ | ||
| public init(createdAt: String, input: DepositMovement, out: DepositMovement, transactionId: String, type: String) { |
There was a problem hiding this comment.
Update from out to output.
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
from
60d83ed to
c6eec06
Compare
|
Updated @SandroMachado . |
| let expectation = expectationWithDescription("Reserve test.") | ||
| let json: String = "[{ \"id\": \"foobar\" }, { \"id\": \"foobiz\" }]" | ||
| let reserve = UpholdClient().getReserve() | ||
| reserve.adapter = MockRestAdapter(body: json) |
There was a problem hiding this comment.
WDYT of adding a new line before reserve.adapter = MockRestAdapter(body: json)?
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
from
c6eec06 to
1733507
Compare
|
Updated @SandroMachado . |
|
|
||
| let json: String = "[" + | ||
| "{" + | ||
| let json: String = "[{" + |
There was a problem hiding this comment.
Please fix the indentation.
diogoguimaraes
force-pushed
the
feature/add-reserve
branch
from
1733507 to
f5479d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the reserve model and the reserve service methods to the Uphold client.