Add Uphold client #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogoguimaraes
force-pushed
the
feature/add-uphold-client
branch
from
17b3c71 to
2801939
Compare
| public override init() { | ||
| super.init() | ||
|
|
||
| self.bearerToken = nil |
There was a problem hiding this comment.
The self.bearerToken = nil is already nil. We don't need to set it to nil.
diogoguimaraes
force-pushed
the
feature/add-uphold-client
branch
from
2801939 to
0922e07
Compare
| } | ||
|
|
||
| /** | ||
| Gets all exchanges rates for all currency pairs. |
There was a problem hiding this comment.
Change to Gets all the exchange rates for all currency pairs..
diogoguimaraes
force-pushed
the
feature/add-uphold-client
branch
from
0922e07 to
af5d9a4
Compare
| public class Token: BaseModel { | ||
|
|
||
| /// The bearer token. | ||
| public private(set) var bearerToken: String? |
There was a problem hiding this comment.
The getter should also be private.
diogoguimaraes
force-pushed
the
feature/add-uphold-client
branch
from
af5d9a4 to
6187fd7
Compare
|
Updated @SandroMachado |
|
|
||
| let client = UpholdClient() | ||
| client.token.adapter = MockRestAdapter(body: json) | ||
| client.getTickers().then { (rates: [Rate]) -> () in |
diogoguimaraes
force-pushed
the
feature/add-uphold-client
branch
from
6187fd7 to
7810f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the Uphold client with the ticker service methods.