Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial project structure #1

Merged
merged 3 commits into from
Aug 5, 2015
Merged

Conversation

SandroMachado
Copy link
Contributor

No description provided.

@SandroMachado SandroMachado force-pushed the feature/project-structure branch from 1c32896 to 0a1bdc6 Compare June 11, 2015 12:18
@SandroMachado
Copy link
Contributor Author

R = @nunofgs

@SandroMachado SandroMachado force-pushed the feature/project-structure branch from 0a1bdc6 to 30c8103 Compare June 12, 2015 11:59
@@ -0,0 +1,38 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments.

@nunofgs
Copy link
Contributor

nunofgs commented Jun 17, 2015

Also, when possible, try to separate project file updates into their own commit as they can be hard to read.

@SandroMachado SandroMachado force-pushed the feature/project-structure branch 4 times, most recently from b799cf7 to e1dea55 Compare July 17, 2015 17:45
@SandroMachado
Copy link
Contributor Author

@nunofgs Updated. Please see my comments above.

@SandroMachado SandroMachado force-pushed the feature/project-structure branch 2 times, most recently from 0da9b57 to 4ee33d7 Compare August 4, 2015 11:38
@SandroMachado
Copy link
Contributor Author

@nunofgs Updated with the new Podfile configuration and Project/Workspace rename

@@ -0,0 +1,21 @@
Pod::Spec.new do |s|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cocoapods now defaults to podspec's written in JSON format. There is a cocoapods command to convert Ruby podspecs into JSON to ease the process. Can you convert it please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@SandroMachado SandroMachado force-pushed the feature/project-structure branch from 4ee33d7 to 417bd13 Compare August 5, 2015 13:58
@SandroMachado
Copy link
Contributor Author

@nunofgs updated.

nunofgs added a commit that referenced this pull request Aug 5, 2015
@nunofgs nunofgs merged commit e9c1099 into master Aug 5, 2015
@nunofgs nunofgs deleted the feature/project-structure branch August 5, 2015 17:11
@nunofgs nunofgs changed the title Initial project structure Add initial project structure Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants