Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-Branch: Bootstrap Removal from OSS components #390

Closed
wants to merge 2 commits into from

Conversation

OwenCoogan
Copy link
Contributor

What does this PR do?

This is the base branch for bootstrap removal on OSS-component , starting with the addage of the less reset file ( with cleanup of the reset added with *{ selector } )
& the removal of the bootstrap css import.

This is the backbone of the whole "feature" in which I will merge all other component removals , starting with upf-slider & the enable-popover modifier.

Related to: #

https://linear.app/upfluence/issue/VEL-2373/cleanup-oss-components-from-bootstrap

What are the observable changes?

aside from the reworked popover & slider components, the idea is that the transition should be seemless

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants