static_href , lang-exclusive, polyglot 1.4.0 prep #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
untra
commented
Feb 7, 2021
untra
commented
- The pull request is complete according to the Definition of Done
- Acceptance criteria in the ticket have been met
- Automated tests are written according to the test plan
- The documentation is up-to-date
- The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
- created to address the following issues:
- jemoji plugin interferes with Polyglot leading space in href #120
- Not relativizing urls #116
- Feature Request: Allow Disabling of post/page translation for single post/page and exlcude them from other language-sites. #63
untra
added a commit
that referenced
this pull request
Feb 8, 2021
* wip * rubocop works again * preparing 1.3.5, ready for further testing * tweaks to how the regexes are called * tweaky tweaky * Static_Href tag is working nicely * mild file renaming and additional tag exposure * Sun Jan 31 17:53:41 MST 2021 * Sun Jan 31 17:56:49 MST 2021 * polyglot 1.4.0 blog posts * support and tests for lang-exclusive * readme and gem version bumps * no .jekyll-cache, no layout * lang-exclusive promo, prep v1.4.0 * dont commit that * final touchups * jekyll build * will this build in .circleci correctly? * pppfff * commit the gemfile.lock * add test group rspec support * update the spec * pages rebuilt, posts added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.