(fix): search option text shrinking in autocomplete #949
Conversation
This reverts commit 1acd87e.
| @@ -113,7 +113,7 @@ function PageWrapper(props) { | |||
| } else if (searchType === SearchType.PROJECTS) { | |||
| completions = await api.autocompleteProjects({ query, token }); | |||
| completions = completions | |||
| .filter(c=>( c.creator.id === props.auth.id && c.publish.type !== 1 )) | |||
| // .filter(c=>( c.creator.id === props.auth.id && c.publish.type !== 1 )) | |||
There was a problem hiding this comment.
I will delete this line if there is no need to filter the projects and show all of them
There was a problem hiding this comment.
We should show all projects here. I think we should remove this line and test if this works fine. This could be a regressions as Raymond suggests here: #419 (comment)
| flexGrow: 1, | ||
| overflow: 'hidden', | ||
| textOverflow: 'ellipsis', | ||
| //first approach |
There was a problem hiding this comment.
the first approach was keeping the username at right for big screens. You can see the comparison here
There was a problem hiding this comment.
Lets mover username below. I also wanted to highlight that for smaller screens where the title gets split in two lines and we get one more username line below, we need to align all this within the height of the image so everything looks proportional. At this time, it is bleeding from top and bottom a bit. Take design help if needed.
|
@brrkrmn I left some comments for you on the main issue |
|
@tuxology pushed the changes that you mentioned above:
|
The project title in the autocomplete options shrinks, making it hard to identify the project. Following the approach in #467 , I made changes to the option styles so that the title is visible in all screens.
Closes #419
Changes
Screenshots
Here is the 3 different sizes:
And here is the options with different title and username length:
Regarding the username length and other possible placements of it, I encourage you to check my comment