(feat) Redirect users to the page they were on before being logged out #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderatomy
commented
Oct 20, 2023
| @@ -37,7 +37,15 @@ export const login = args => { | |||
| payload: { token: res.key }, | |||
| }); | |||
| }) | |||
| .then(() => args.history.push('/')); | |||
| .then(() => { | |||
| const initialUrl = sessionStorage.getItem('initialUrl'); | |||
There was a problem hiding this comment.
getting the initailUrl from the sessionStorage
coderatomy
commented
Oct 20, 2023
| @@ -124,6 +124,9 @@ class API { | |||
| * @todo - describe method's signature | |||
| */ | |||
| logout = token => { | |||
| const initialUrl = window.location.href | |||
| sessionStorage.setItem('initialUrl', initialUrl) | |||
There was a problem hiding this comment.
saving the initialUrl in sessionStorage when logging out
tuxology
approved these changes
Oct 20, 2023
| @@ -1,7 +1,7 @@ | |||
| import React, { useContext } from 'react'; | |||
| import { withTranslation } from 'react-i18next'; | |||
| import { BrowserRouter as Router, Route, Redirect, Switch } from 'react-router-dom'; | |||
| import CreateActivity from './views/create_activity/create_activity'; | |||
| import CreateActivity from './views/create_activity/CreateActivity'; | |||
There was a problem hiding this comment.
Won't conflict. I merged the regression commit into this since it was blocking.
tuxology
approved these changes
Oct 20, 2023
Merged
NdibeRaymond
pushed a commit
that referenced
this pull request
May 19, 2024
* fix routing * fix pagewrapper * remove previous protected route features and reimplement (was defective) * revert #931 (implementation is defective) * implement redirection feature ( when you try to visit a protected route, you get redirected to the login page instead of the pagenotfound error, and after logging in you get redirected back to the protected page you initially wanted to visit) Issue: #1127 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]>
Merged
NdibeRaymond
added a commit
that referenced
this pull request
May 19, 2024
* fix routing * fix pagewrapper * remove previous protected route features and reimplement (was defective) * revert #931 (implementation is defective) * implement redirection feature ( when you try to visit a protected route, you get redirected to the login page instead of the pagenotfound error, and after logging in you get redirected back to the protected page you initially wanted to visit) Issue: #1127 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]> Co-authored-by: Ndibe Raymond Olisaemeka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Save the
initalUrlin thesessionStoragewhen logging out and removes it immediately after logging inCloses #924
Changes
initialUrlin sessionStorageScreencasts
Screencast.from.2023-10-20.08-30-06.webm