-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error messages in Login and EditProfile forms for required fields #839
Show error messages in Login and EditProfile forms for required fields #839
Conversation
This reverts commit 748b18f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this patch @tuxology and it works as described, but I've been away from the project for some time now so you should probably take a look too especially when it comes to commit practices
@brrkrmn it seems like the following files |
Sure, on it |
Summary
When trying to submit the login and editProfile forms without filling the required fields, no error message or feedback is given to the user.
If the user focuses on an input and then leaves it empty, the error message is seen, however, if the input is blank and not touched by the user until the submission, no message is shown.
Closes #838
Changes
setFieldTouched
in their submit functions. I chose this approach for consistency because the signup form uses it for all its inputs.Final Results:
branch-edit.mov
ts/92817363/070d39bb-3cc7-4f56-8c10-342d792138b1
branch-login.mov