Add violations backend code #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewLester
requested review from
NdibeRaymond,
tuxology and
ajain1921
as code owners
AndrewLester
force-pushed
the
al/violations-backend
branch
from
4c2260b to
6f8a3a7
Compare
ajain1921
reviewed
Apr 29, 2022
Comment on lines
+610
to
+631
| class ProjectViolationsClearApiView(APIView): | ||
| """ | ||
| Clear all violations for a project | ||
|
|
||
| Requires authentication and owner. | ||
| Returns project details. | ||
| """ | ||
|
|
||
| permission_classes = [IsAuthenticated, IsOwner] | ||
| throttle_classes = [CustomUserRateThrottle, SustainedRateThrottle] | ||
|
|
||
| def post(self, request, *, pk): | ||
| try: | ||
| old = Project.objects.get(pk=pk) | ||
| except Project.DoesNotExist: | ||
| return Response('Not found', status=404) | ||
|
|
||
| if not request.user or old.creator.id != request.user.id: | ||
| return Response('Error', status=403) | ||
|
|
||
| old.violations.set([]) | ||
| old.save() |
There was a problem hiding this comment.
Couldn't we add this functionality to the update function in the ProjectSerializer? This would also prevent the user from having to make two api calls on the frontend when updating a project.
There was a problem hiding this comment.
We could, but I feel like that's going to be replaced pretty quickly in the future when actual moderation is implemented. This system is more extensible imo. I feel like 2 API calls isn't much of a problem, but I can replace this if we're sure.
ajain1921
reviewed
Apr 29, 2022
Comment on lines
635
to
653
| class ProjectViolationAddApiView(CreateAPIView): | ||
| """ | ||
| Creates a new violation and adds it to a project. | ||
|
|
||
| Requires authentication and staff or moderator. | ||
| Returns the violation details. | ||
| """ | ||
| queryset = Violation.objects.all() | ||
| serializer_class = ViolationSerializer | ||
| permission_classes = [IsAuthenticated, IsStaffOrModerator] | ||
| throttle_classes = [PostUserRateThrottle, SustainedRateThrottle] | ||
|
|
||
| def perform_create(self, serializer): | ||
| pk = self.kwargs.get("pk") | ||
| project = Project.objects.get(id=pk) | ||
| violation = serializer.save(creator=self.request.user, project=project) | ||
| project.violations.add(violation) | ||
| project.save() | ||
| return violation |
There was a problem hiding this comment.
Send notification to user to let them know their project was unpublished.
There was a problem hiding this comment.
Does this mean we need a new notification type?
|
Can you also pre-load the |
ajain1921
added a commit
that referenced
this pull request
May 10, 2022
* Init * Unpublish project form (#452) * Lay out structure * Make progress * Style menu * Style checkboxes & buttons * Add api call * Make mobile-friendly * Last styling changes * Address styling comments * Remove for non-staff & non-moderators * Add violations backend code (#447) * Add violations backend system * Fix typo * Add new migrations * Basic * Use array * Fix issuesgit status * Swap fetch parameter * Add responses * Add new violation ui for violation notifications * Fix models Co-authored-by: Aditya Jain <[email protected]> * Unpublished Project Modal (#446) * set up modal * style changes * change to label and mobile styles * tiny fix of class style * scrolling * tiny style fix * clean up unused things * overflow scroll bar adjustments * Small style * remove important Co-authored-by: Aditya Jain <[email protected]> * Integrate Co-authored-by: Grace Zhang <[email protected]> Co-authored-by: Andrew Lester <[email protected]> Co-authored-by: Zora Zhang <[email protected]>
NdibeRaymond
pushed a commit
that referenced
this pull request
Jun 5, 2022
* Init * Unpublish project form (#452) * Lay out structure * Make progress * Style menu * Style checkboxes & buttons * Add api call * Make mobile-friendly * Last styling changes * Address styling comments * Remove for non-staff & non-moderators * Add violations backend code (#447) * Add violations backend system * Fix typo * Add new migrations * Basic * Use array * Fix issuesgit status * Swap fetch parameter * Add responses * Add new violation ui for violation notifications * Fix models Co-authored-by: Aditya Jain <[email protected]> * Unpublished Project Modal (#446) * set up modal * style changes * change to label and mobile styles * tiny fix of class style * scrolling * tiny style fix * clean up unused things * overflow scroll bar adjustments * Small style * remove important Co-authored-by: Aditya Jain <[email protected]> * Integrate Co-authored-by: Grace Zhang <[email protected]> Co-authored-by: Andrew Lester <[email protected]> Co-authored-by: Zora Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #428
Changes
Requests / Responses
GET `/projects/violation-reasons` Returns violation reasons
Response
[{"id":"862a8a5a-78a6-491c-808c-568b784d7743","description":"DID AN OOPSIE!"}]PUT `/projects/:uuid/clear-violations` Clears a project's violations
Request
No body
Response
"Success"POST `/projects/:uuid/add-violation` Adds a violation
Request
{"reasons": [{"id": "862a8a5a-78a6-491c-808c-568b784d7743"}]}Response
{"id":"37e88233-b1dd-40fe-9783-fdfbcabc215a","reasons":[{"id":"862a8a5a-78a6-491c-808c-568b784d7743","description":"DID AN OOPSIE!"}],"creator":"62ab5343-36d4-449b-9c2f-2c796cae27ff","date":"2022-04-28T02:46:47.186095Z","project":"542c8806-5db9-4890-9bea-2b0ad2b94c5c"}