Make "Tinkering Resources" footer link editable and attach to frontend #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added updates to the frontend development setup.
This reverts commit 5424b5c.
* Finish creators and projects search migration * Finish creators and projects search migration * Add tag search * Add search for projects with tags * Fix search bar on mobile * use 0 rather than 0 with units in css * Remove print * Default search type to projects * Disable scroll lock
…nstructuredstudio#369) * improveConsistency: fixed title text small, extra vertical space and inconsitent padding of buttons
khabdrick
requested review from
NdibeRaymond,
tuxology and
ajain1921
as code owners
khabdrick
changed the title
NdibeRaymond
requested changes
Apr 11, 2022
| @@ -113,6 +113,8 @@ function PageWrapper(props) { | |||
| const { anchor_el, loading, open_search_form } = state; | |||
| const { t } = props; | |||
| const { zubhub } = props.projects; | |||
There was a problem hiding this comment.
const { zubhub, hero } = props.projects;
NdibeRaymond
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the
tinkering_resource_urlto Hero model and also altered the frontend to use thetinkering_resource_url.Closes #345
Changes
tinkering_resource_urlfield to the Hero model, serializer and view.kriti.unstructured.studioif the tinkering_resource_url is empty.Please pardon the numerous commits, I messed up with some git commands. It won't happen again.