Fixed issue #221 Buttons in Project Page on mobile need realignment #374
Conversation
alicendeh
requested review from
NdibeRaymond,
tuxology and
ajain1921
as code owners
alicendeh
changed the title
| boxShadow: | ||
| '0px 3px 1px -2px rgba(0,0,0,0.2), 0px 2px 2px 0px rgba(0,0,0,0.14), 0px 1px 5px 0px rgba(0,0,0,0.12)', | ||
| [theme.breakpoints.down('1080')]: { | ||
| position: 'static', | ||
| height: '3.5em', | ||
| width: '100%', | ||
| flexDirection: 'row', | ||
| justifyContent: 'flex-start', | ||
| justifyContent: 'space-around', |
There was a problem hiding this comment.
Looking at the visual effect, this doesn't look so great. I think you should leave it at flex-start. you only need to remove the padding in the clap button because it is the reason the spacing between the clap button and the other icons are not the same.
|
@alicendeh thanks for working on this issue. few comments:
|
|
Alright, thanks @NdibeRaymond ill fix that and push. |
fixed failed to load api specification error (unstructuredstudio#363) fixed failed to load api specification error added style to fix text wrap (unstructuredstudio#373) Add hot reloading to media container (unstructuredstudio#382) Add new search features (unstructuredstudio#362) * Finish creators and projects search migration * Finish creators and projects search migration * Add tag search * Add search for projects with tags * Fix search bar on mobile * use 0 rather than 0 with units in css * Remove print * Default search type to projects * Disable scroll lock Revert package-lock (unstructuredstudio#383) improveConsistency: fixed title text small, extra vertical space ... (unstructuredstudio#369) * improveConsistency: fixed title text small, extra vertical space and inconsitent padding of buttons fix text overflow issue in signup page phone number field (unstructuredstudio#378) removed spacing between icons
|
Hey @NdibeRaymond can you take a look now? |
|
@alicendeh you now have 19 files changed. It seems like while trying to squash you rebased the commits of others as well? squashing should only be for your own commits. If this takes too much time to fix, just move over your OWN changes into a new branch, close this PR and reopen a new PR with the new branch. |
Let me do that |
Summary
Closes #211
Changes
-Made the Edit button to be right-aligned and placed along with the Delete button
-Spaced Clap, bookmark, and views button equally
Screenshots